feat(validation): enforce the pinned Agent Skills instruction-body rule with ecosystem-lint provenance (#133) - #334
Merged
Conversation
🦋 Changeset detectedLatest commit: ccc8ef4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Agent Skills spec-lint slice of #133, resolved under the issue's honesty rules:
@skill-tools/core@0.2.2evaluated, not integrated (2026-09-02): the package is genuine (github.com/skill-tools/skill-tools, Apache-2.0 — not one of the npm squats the issue warns about), but its lint is lower fidelity than the pinned contract: it pins no spec revision, its description-length warning is internally inconsistent (fires <10 chars, message says 50), it accepts unknown frontmatter extensions the pinned closed schema rejects, and it downgrades name/directory mismatch to a warning where the pinned spec mandates equality. Full dated evaluation — npm metadata, tarball sha1/integrity, the 17 observed rule ids, six limitations — recorded inschemas/agent-skills/PROVENANCE.jsonand pinned by the schema test.SKILL.mdwith valid frontmatter but no Markdown instruction body now fails artifact validation asAB6034(registered with recovery; recovery-coverage test updated), matching the pinned spec's frontmatter-followed-by-content requirement. Negative fixture added; two existing empty-body fixtures updated to carry instructions.Changeset: minor,
agent-bundle.Test plan (all local, on the rebase over e84ec83)
pnpm buildpnpm typecheckpnpm lint— 0 errors, 0 warnings (1019 files)pnpm test:unit— 2615 passed, 0 failed, 5 skippedTracking